Skip to content

Conversation

@santigimeno
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

c++

Description of change

I was getting these warnings on OS X locally:

../src/node_util.cc:138:43: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
    PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V)
                                          ^~
../src/env.h:56:3: note: expanded from macro 'PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES'
  V(alpn_buffer_private_symbol, "node:alpnBuffer")                            \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/node_util.cc:133:3: note: expanded from macro 'V'
  target->Set(context,                                                        \
  ^~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/node_util.cc:138:43: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
    PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V)
                                          ^~
../src/env.h:57:3: note: expanded from macro 'PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES'
  V(arrow_message_private_symbol, "node:arrowMessage")                        \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/node_util.cc:133:3: note: expanded from macro 'V'
  target->Set(context,                                                        \

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 8, 2016
@jasnell
Copy link
Member

jasnell commented Sep 8, 2016

LGTM

@addaleax
Copy link
Member

addaleax commented Sep 8, 2016

@Trott
Copy link
Member

Trott commented Sep 8, 2016

CI failures are one known flaky on Linux and one apparent CI infra failure on Raspberry Pi. Seemingly unrelated to this change.

@bnoordhuis
Copy link
Member

LGTM but can you s/unused-result/-Wunused-result/ in the commit log?

@fhinkel
Copy link
Member

fhinkel commented Sep 9, 2016

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Sep 9, 2016

LGTM

PR-URL: nodejs#8450
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@santigimeno santigimeno merged commit cc00be6 into nodejs:master Sep 9, 2016
@santigimeno
Copy link
Member Author

Landed in cc00be6 with commit log amended

@Fishrock123
Copy link
Contributor

Depends on #7082. Please mark these as dont-land-on-v6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants