test: remove FIXME pummel/test-tls-securepair-client #8757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts: 85827bd Refs: nodejs#4640 Using `common.PORT` no longer causes other tests to fail
|
LGTM if CI is green. |
|
It seems that most of the builds are failing https://ci.nodejs.org/job/node-test-pull-request/ maybe infrastructure issues still? |
|
Note that pummel tests are not run in CI, so the CI is basically only valuable for the linting in this case. Test seems to work as expected with the change, so LGTM. /cc @bnoordhuis |
jasnell
approved these changes
Oct 6, 2016
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Reverts: 85827bd Using `common.PORT` no longer causes other tests to fail Refs: #4640 PR-URL: #8757 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 647e8e5 |
jasnell
pushed a commit
that referenced
this pull request
Oct 10, 2016
Reverts: 85827bd Using `common.PORT` no longer causes other tests to fail Refs: #4640 PR-URL: #8757 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Reverts: 85827bd Using `common.PORT` no longer causes other tests to fail Refs: #4640 PR-URL: #8757 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Reverts: 85827bd Using `common.PORT` no longer causes other tests to fail Refs: #4640 PR-URL: #8757 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Reverts: 85827bd
Refs: #4640
Using
common.PORTno longer causes other tests to failCurrently runningmake -j4 testreturns errors for parallel/test-internal-modules and parallel/test-repl but that seems to be unrelated to this pull request.It seems that there's something unusual going on with the VM I use to build