Skip to content

Docker: Add .dockerignore file in guide #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2016
Merged

Docker: Add .dockerignore file in guide #1022

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb33109
Add simple .dockerignore file for node
tpreusse Nov 12, 2016
105c5bb
Expand .dockerignore explanation
tpreusse Nov 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add simple .dockerignore file for node 
Without it `COPY . /usr/src/app` will possibly overwrite node_modules inside the image
  • Loading branch information
@tpreusse
tpreusse authored Nov 12, 2016
commit eb33109494d56c2a0ed92a94d187aaafe8dea576
9 changes: 9 additions & 0 deletions locale/en/docs/guides/nodejs-docker-webapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,15 @@ EXPOSE 8080
CMD [ "npm", "start" ]
```

## .dockerignore file

Prevent your local modules and debug log from being copied into your Docker image:
Copy link
Contributor

@ryanmurakami ryanmurakami Nov 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just make this statement a little clearer, something like:
To prevent your local modules and debug logs from being copied onto your Docker image, create a .dockerignore file with the below contents:

Also, you should mention where this file will go.


```
node_modules
npm-debug.log
```

## Building your image

Go to the directory that has your `Dockerfile` and run the following command to
Expand Down