Skip to content

make Korean docs up-to-date #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2017
Merged

make Korean docs up-to-date #1032

merged 1 commit into from
Feb 9, 2017

Conversation

outsideris
Copy link
Contributor

follow changed in English and #1022

@outsideris
Copy link
Contributor Author

@nodejs/nodejs-ko

yous
yous reviewed Nov 28, 2016
View reviewed changes
locale/ko/about/working-groups.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change (`Node.js` → Node.js) is not applied to the translation.

locale/ko/about/working-groups.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please change `nodejs.org` to nodejs.org, `Node.js` to Node.js in translation.

locale/ko/about/working-groups.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'readable-stream' as is instead of '읽기 가능한 스트림', as it's a package name.

locale/ko/about/working-groups.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about '광범위한'?

locale/ko/about/working-groups.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe '`async_hooks`를' here.

locale/ko/about/working-groups.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this empty line in translation.

locale/ko/download/package-manager.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHEL, CentOS or Fedora → RHEL, CentOS, Fedora

locale/ko/download/package-manager.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not applied in translation.

locale/ko/download/package-manager.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not applied in translation.

locale/ko/download/package-manager.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not applied in translation.

@outsideris
Copy link
Contributor Author

I updated as feedback. Thank you.

@outsideris
Copy link
Contributor Author

I rebased it on master to fix the build failure.

@fhemberger
Copy link
Contributor

@outsideris Hi, could you please rebase it again and fix the conflict? Then I'd be happy to merge it.

@outsideris
Copy link
Contributor Author

@fhemberger Sorry, I forgot it. I will address it.

@sotayamashita
Copy link
Contributor

sotayamashita commented Feb 4, 2017 •
edited
Loading

@outsideris I think you should follow the commit message in TRANSLATION.md

For example:

nodejs-ko: up-to-date

@outsideris
Copy link
Contributor Author

@sotayamashita Oops! I didn't know the rule. I will fix commit messages in this PR.

@outsideris
Copy link
Contributor Author

@fhemberger @sotayamashita I rebased it and fixed the commit message.

@nodejs/nodejs-ko Please review this. I made this pull request about 2 months ago. In this time, I just rebase it onto latest matser branch.

@marocchino marocchino self-requested a review February 8, 2017 06:21
yous
yous reviewed Feb 8, 2017
View reviewed changes
locale/ko/about/working-groups.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean '정제합니다'?

locale/ko/docs/guides/nodejs-docker-webapp.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please insert a new line above this line.
  • 다음 내용을 → 다음 내용으로

@outsideris
Copy link
Contributor Author

I updated it. @yous Thank you for review.

@fhemberger fhemberger merged commit 87233c0 into nodejs:master Feb 9, 2017
@fhemberger
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@marocchino marocchino marocchino approved these changes

@yous yous yous approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@outsideris @fhemberger @sotayamashita @marocchino @yous