Fix typos #1130

bf4 · 2017-02-06T01:23:08Z

Hope this is ok...

go get -u github.com/client9/misspell/cmd/misspell
misspell  -w -error -source=text .

bf4 · 2017-02-06T02:03:01Z

Related nodejs/node#11189

bf4 · 2017-02-06T02:03:23Z

locale/en/blog/release/v0.5.10.md

I didn't spell check other locales

sotayamashita · 2017-02-06T03:26:18Z

@bf4 Please write affected directories

fhemberger

Nice catch! Maybe we should add this spell checker to our build process (checking in the binary only). /cc @nodejs/website

thefourtheye · 2017-02-06T07:58:33Z

locale/en/blog/release/v4.5.0.md

Same concern from the other PR. Commit log should not change..

Personally, I have no problem with that as all relevant information stays intact.

@thefourtheye I agree with @thefourtheye because If I change document under release/, there is a difference between commit message in history.

bf4 · 2017-02-06T17:24:25Z

@sotayamashita @fhemberger @thefourtheye should I wait for any more comments?

@sotayamashita github lazy hack: https://patch-diff.githubusercontent.com/raw/nodejs/nodejs.org/pull/1130.patch -->

 TRANSLATION.md                                     |  2 +-
 locale/en/about/trademark.md                       |  2 +-
 locale/en/blog/release/v0.5.10.md                  |  2 +-
 locale/en/blog/release/v0.5.5.md                   |  2 +-
 locale/en/blog/release/v4.5.0.md                   |  2 +-
 locale/en/blog/release/v5.10.1.md                  |  2 +-
 locale/en/blog/release/v6.3.1.md                   |  2 +-
 .../node-interactive-convince-boss.md              |  2 +-
 locale/en/blog/vulnerability/openssl-march-2016.md |  4 +-
 .../weekly-updates/weekly-update.2015-02-13.md     |  2 +-
 locale/en/foundation/case-studies.md               |  2 +-
 locale/en/foundation/outreachy.md                  |  2 +-
 locale/en/foundation/tsc/minutes/2014-12-10.md     |  2 +-
 locale/en/foundation/tsc/minutes/2015-01-22.md     |  2 +-
 locale/en/foundation/tsc/minutes/2015-02-09.md     |  4 +-
 locale/en/foundation/tsc/minutes/2015-03-19.md     |  2 +-
 locale/en/foundation/tsc/minutes/2015-04-24.md     |  2 +-
 locale/en/foundation/tsc/minutes/2015-04-30.md     |  4 +-
 locale/en/get-involved/events.md                   | 98 +++++++++++-----------
 .../HTTP/clients/how-to-create-a-HTTP-request.md   |  4 +-
 .../HTTP/servers/how-to-read-POST-data.md          |  4 +-
 .../file-system/how-to-use-the-path-module.md      |  2 +-
 .../control-flow/what-are-callbacks.md             |  4 +-
 .../control-flow/what-are-event-emitters.md        |  4 +-
 .../knowledge/getting-started/npm/what-is-npm.md   |  2 +-
 .../npm/what-is-the-file-package-json.md           |  2 +-
 ...w-to-create-default-parameters-for-functions.md |  2 +-
 .../what-are-the-built-in-timer-functions.md       |  6 +-
 .../javascript-conventions/what-is-json.md         |  4 +-
 scripts/release-post.js                            |  4 +-
 static/js/dnt_helper.js                            |  2 +-
 31 files changed, 90 insertions(+), 90 deletions(-)

sotayamashita · 2017-02-07T00:55:41Z

@bf4 Thanks. I think you should wait until that @thefourtheye accept your PR.

sotayamashita · 2017-02-07T00:56:28Z

@thefourtheye @fampinheiro Who has a permission to merge PR in node/node.js.org ?

fhemberger · 2017-02-07T04:09:48Z

@sotayamashita I can do that, if everybody is fine with the PR in its current state.

fhemberger · 2017-02-07T06:26:24Z

@bf4 Okay, to get this to land, please revert changes in the commit history list of

locale/en/blog/release/v4.5.0.md
locale/en/blog/release/v6.3.1.md

and we're good to go.

``` go get -u github.com/client9/misspell/cmd/misspell misspell -w -error -source=text . ``` modified: TRANSLATION.md modified: locale/en/about/trademark.md modified: locale/en/blog/uncategorized/node-interactive-convince-boss.md modified: locale/en/blog/vulnerability/openssl-march-2016.md modified: locale/en/blog/weekly-updates/weekly-update.2015-02-13.md modified: locale/en/foundation/case-studies.md modified: locale/en/foundation/outreachy.md modified: locale/en/foundation/tsc/minutes/2014-12-10.md modified: locale/en/foundation/tsc/minutes/2015-01-22.md modified: locale/en/foundation/tsc/minutes/2015-02-09.md modified: locale/en/foundation/tsc/minutes/2015-03-19.md modified: locale/en/foundation/tsc/minutes/2015-04-24.md modified: locale/en/foundation/tsc/minutes/2015-04-30.md modified: locale/en/get-involved/events.md modified: locale/en/knowledge/HTTP/clients/how-to-create-a-HTTP-request.md modified: locale/en/knowledge/HTTP/servers/how-to-read-POST-data.md modified: locale/en/knowledge/file-system/how-to-use-the-path-module.md modified: locale/en/knowledge/getting-started/control-flow/what-are-callbacks.md modified: locale/en/knowledge/getting-started/control-flow/what-are-event-emitters.md modified: locale/en/knowledge/getting-started/npm/what-is-npm.md modified: locale/en/knowledge/getting-started/npm/what-is-the-file-package-json.md modified: locale/en/knowledge/javascript-conventions/how-to-create-default-parameters-for-functions.md modified: locale/en/knowledge/javascript-conventions/what-are-the-built-in-timer-functions.md modified: locale/en/knowledge/javascript-conventions/what-is-json.md modified: scripts/release-post.js modified: static/js/dnt_helper.js

bf4 · 2017-02-07T16:07:34Z

@fhemberger rebased and force pushed so that diff is now

 TRANSLATION.md                                                                               |  2 +-
 locale/en/about/trademark.md                                                                 |  2 +-
 locale/en/blog/uncategorized/node-interactive-convince-boss.md                               |  2 +-
 locale/en/blog/vulnerability/openssl-march-2016.md                                           |  4 ++--
 locale/en/blog/weekly-updates/weekly-update.2015-02-13.md                                    |  2 +-
 locale/en/foundation/case-studies.md                                                         |  2 +-
 locale/en/foundation/outreachy.md                                                            |  2 +-
 locale/en/foundation/tsc/minutes/2014-12-10.md                                               |  2 +-
 locale/en/foundation/tsc/minutes/2015-01-22.md                                               |  2 +-
 locale/en/foundation/tsc/minutes/2015-02-09.md                                               |  4 ++--
 locale/en/foundation/tsc/minutes/2015-03-19.md                                               |  2 +-
 locale/en/foundation/tsc/minutes/2015-04-24.md                                               |  2 +-
 locale/en/foundation/tsc/minutes/2015-04-30.md                                               |  4 ++--
 locale/en/get-involved/events.md                                                             | 98 +++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------
 locale/en/knowledge/HTTP/clients/how-to-create-a-HTTP-request.md                             |  4 ++--
 locale/en/knowledge/HTTP/servers/how-to-read-POST-data.md                                    |  4 ++--
 locale/en/knowledge/file-system/how-to-use-the-path-module.md                                |  2 +-
 locale/en/knowledge/getting-started/control-flow/what-are-callbacks.md                       |  4 ++--
 locale/en/knowledge/getting-started/control-flow/what-are-event-emitters.md                  |  4 ++--
 locale/en/knowledge/getting-started/npm/what-is-npm.md                                       |  2 +-
 locale/en/knowledge/getting-started/npm/what-is-the-file-package-json.md                     |  2 +-
 locale/en/knowledge/javascript-conventions/how-to-create-default-parameters-for-functions.md |  2 +-
 locale/en/knowledge/javascript-conventions/what-are-the-built-in-timer-functions.md          |  6 +++---
 locale/en/knowledge/javascript-conventions/what-is-json.md                                   |  4 ++--
 scripts/release-post.js                                                                      |  4 ++--
 static/js/dnt_helper.js                                                                      |  2 +-

fhemberger · 2017-02-07T19:01:07Z

Great, thank you!

thefourtheye · 2017-02-08T02:28:05Z

Cool.... 👍

bf4 · 2017-02-09T16:39:47Z

locale/en/get-involved/events.md

          <p><span><b>=== En general ===&nbsp;</b></span></p>
          <p><span>Las últimas tecnologías para el desarrollo Web y Móvil, siguiendo las filosofías Lean Startup, Mobile First, NoSQL, NoBackend, Agile Development, Gamification.</span></p>
-          <p><span>Si eres Entrepreneur / Emprendeodor, entonces necesitas conocer los mejores entornos de desarrollo, y estar al día. Aprende, Crece, Comparte</span></p>
+          <p><span>Si eres Entrepreneur / Emprendeodor, entonces necesitas conocer los mejores entornos de desarrollo, y estar al día. Aprende, Crece, Compare</span></p>


oh shoot! there were not en-US languages in here! ref #1128

As noted in nodejs#1128, there was non-English that was erroneously modified in nodejs#1130

#1137) As noted in #1128, there was non-English that was erroneously modified in #1130

bf4 commented Feb 6, 2017

View reviewed changes

locale/en/blog/release/v0.5.10.md Outdated

Copy link

Contributor Author

bf4 Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't spell check other locales

fhemberger approved these changes Feb 6, 2017

View reviewed changes

thefourtheye reviewed Feb 6, 2017

View reviewed changes

bf4 force-pushed the correct_spelling branch from edb3778 to 2694454 Compare February 7, 2017 16:07

fhemberger merged commit 1f88188 into nodejs:master Feb 7, 2017

bf4 deleted the correct_spelling branch February 7, 2017 19:11

pin3da mentioned this pull request Feb 9, 2017

Update events.md #1128

Closed

bf4 commented Feb 9, 2017

View reviewed changes

bf4 mentioned this pull request Feb 9, 2017

Revert changes to non-English text in locale/en/get-involved/events.md #1137

Merged

bf4 added a commit to bf4/nodejs.org that referenced this pull request Feb 9, 2017

Revert changes to non-English text in locale/en/get-involved/events.md

9c5dacb

As noted in nodejs#1128, there was non-English that was erroneously modified in nodejs#1130

pin3da pushed a commit that referenced this pull request Feb 11, 2017

Revert changes to non-English text in locale/en/get-involved/events.md (

79f3a30

#1137) As noted in #1128, there was non-English that was erroneously modified in #1130

sotayamashita mentioned this pull request Feb 15, 2017

WIP: Add tests for spelling github/opensource.guide#63

Closed

4 tasks

watilde mentioned this pull request May 1, 2017

tools: introduce make mdlint command and tools nodejs/node#12756

Closed

2 tasks

Uh oh!

Fix typos #1130

Fix typos #1130

Uh oh!

Conversation

bf4 commented Feb 6, 2017

Uh oh!

bf4 commented Feb 6, 2017

Uh oh!

bf4 Feb 6, 2017

Choose a reason for hiding this comment

Uh oh!

sotayamashita commented Feb 6, 2017

Uh oh!

fhemberger left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thefourtheye Feb 6, 2017

Choose a reason for hiding this comment

Uh oh!

fhemberger Feb 6, 2017

Choose a reason for hiding this comment

Uh oh!

sotayamashita Feb 7, 2017

Choose a reason for hiding this comment

Uh oh!

bf4 commented Feb 6, 2017

Uh oh!

sotayamashita commented Feb 7, 2017

Uh oh!

sotayamashita commented Feb 7, 2017

Uh oh!

fhemberger commented Feb 7, 2017

Uh oh!

fhemberger commented Feb 7, 2017

Uh oh!

bf4 commented Feb 7, 2017

Uh oh!

fhemberger commented Feb 7, 2017

Uh oh!

thefourtheye commented Feb 8, 2017

Uh oh!

bf4 Feb 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fhemberger left a comment •

edited

Loading

bf4 Feb 9, 2017 •

edited

Loading