Skip to content

Conversation

@bogas04
Copy link
Contributor

@bogas04 bogas04 commented Sep 17, 2015

Fix for #168

screen shot 2015-09-17 at 10 38 51 pm
becomes
screen shot 2015-09-17 at 10 40 31 pm

@phillipj
Copy link
Member

I like the improved readability 👍 Would be nice to get rid of the 3 merge commits though

@bogas04
Copy link
Contributor Author

bogas04 commented Sep 17, 2015

Is there any clean way to do that ? I'm creating a new PR #170 for now though.

@phillipj
Copy link
Member

Is there any clean way to do that ?

git rebase is the key :)

Your new PR seems to have a better history, closing this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants