Skip to content

Conversation

@glaucia86
Copy link
Contributor

Hi guys. I am starting to make some translations some files:

  • index.md
  • 404.md
  • site.json

During the holidays I will still make some Brazilian portuguese translate.
I followed all the instructions on file TRANSLATION.md
Unfortunately the moderator of the i18n group in Portuguese ( @gustavohenke ) has not interactions for almost 1 year. nodejs-pt
With that, I am sending this PR to you.

@bnb @refack and @fhemberger I would love to make my contribution here helping out here.

Kind regards,

@glaucia86

@fhemberger
Copy link
Contributor

Hi, thanks for your contribution!

/cc @nodejs/nodejs-pt Could you please have a look at the translations?

@glaucia86
Copy link
Contributor Author

Hi, thanks for your contribution!

/cc @nodejs/nodejs-pt Could you please have a look at the translations?

Thanks @fhemberger. Now wating for the guys from @nodejs/nodejs-pt. As I said.... has no interaction there almost 1 year. But let's waiting for.

Copy link
Contributor

@Drieger Drieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in @nodejs/nodejs-pt, but I made some suggestions to make this translation clearer. I couldn't check the last file yet but will verify it ASAP

@glaucia86
Copy link
Contributor Author

@Drieger now doing push again on my branch! @Drieger

@glaucia86
Copy link
Contributor Author

@Drieger updated it! :)

Copy link

@rogeriopvl rogeriopvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM 👍

@glaucia86 glaucia86 closed this Dec 18, 2018
@glaucia86 glaucia86 reopened this Dec 18, 2018
@glaucia86
Copy link
Contributor Author

glaucia86 commented Dec 19, 2018

Hi @fhemberger!
Now it's updated it. Everything prepare to merge into master 😃

@stevemao stevemao added i18n Issues/PRs related to the Website Internationalisation and removed on hold/needs i18n +1 labels Dec 19, 2018
@stevemao stevemao merged commit 39a7f4e into nodejs:master Dec 19, 2018
@glaucia86 glaucia86 deleted the portuguese-br-translation branch December 19, 2018 03:46
@glaucia86
Copy link
Contributor Author

Thanks for merging @stevemao

@stevemao
Copy link
Contributor

@glaucia86 NP :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Issues/PRs related to the Website Internationalisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants