Skip to content

fix: no-shortcut-reference-link #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nschonni merged 3 commits into from
May 2, 2020
Merged

fix: no-shortcut-reference-link #2697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e453e6a
fix: no-shortcut-reference-link
nschonni May 1, 2020
7c4f3b1
chore: Disable remark rules in legacy changelogs
nschonni May 1, 2020
9ab3689
Merge branch 'master' into fix--no-shortcut-reference-link
Trott May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Disable remark rules in legacy changelogs
  • Loading branch information
@nschonni
nschonni committed May 1, 2020
commit 7c4f3b189eefdd90c51dd83f979f65000ff85a3e
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.10.42.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-10-42
layout: blog-post.hbs
author: James M Snell
---
<!--lint disable prohibited-strings-->
Copy link
Contributor

@XhmikosR XhmikosR May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm such comments are not in the built HTML? Not a blocker, but we should be aware about it.

Copy link
Member Author

@nschonni nschonni May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks like it ends up the built HTML

<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

This is an important security release. For full details see https://nodejs.org/en/blog/vulnerability/february-2016-security-releases/ for details on patched vulnerabilities.

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.10.44.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-10-44
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

**This is a security release**, upgrading the bundled version of npm due to a credentials leak vulnerability. Further information can be found in our post: https://nodejs.org/en/blog/vulnerability/npm-tokens-leak-march-2016/

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.10.45.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-10-45
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

### Notable changes:

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.10.46.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-10-46
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

### Notable changes:

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.10.47.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-10-47
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

**This is an important security release**. All Node.js users should consult the [security release summary](https://nodejs.org/en/blog/vulnerability/september-2016-security-releases/) at for details on patched vulnerabilities.

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.10.48.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-10-48
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

This is a security release. All Node.js users should consult the security release summary at https://nodejs.org/en/blog/vulnerability/october-2016-security-releases/ for details on patched vulnerabilities.

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.11.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ title: Node v0.11.0 (Unstable)
slug: node-v0-11-0-stable
layout: blog-post.hbs
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

2013.03.28, Version 0.11.0 (Unstable)

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.11.11.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ title: Node v0.11.11 (Unstable)
slug: node-v0-11-11-unstable
layout: blog-post.hbs
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

2014.01.29, Version 0.11.11 (Unstable)

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.12.10.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-12-10
layout: blog-post.hbs
author: James M Snell
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

This is an important security release. For full details see https://nodejs.org/en/blog/vulnerability/february-2016-security-releases/ for details on patched vulnerabilities.

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.12.13.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-12-13
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

**This is a security release**, upgrading the bundled version of npm due to a credentials leak vulnerability. Further information can be found in our post: https://nodejs.org/en/blog/vulnerability/npm-tokens-leak-march-2016/

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.12.15.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-12-15
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

### Notable changes:

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.12.16.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-12-16
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

**This is an important security release**. All Node.js users should consult the [security release summary](https://nodejs.org/en/blog/vulnerability/september-2016-security-releases/) at for details on patched vulnerabilities.

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.12.17.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-12-17
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

This is a security release. All Node.js users should consult the security release summary at https://nodejs.org/en/blog/vulnerability/october-2016-security-releases/ for details on patched vulnerabilities.

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.12.18.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ slug: node-v0-12-18
layout: blog-post.hbs
author: Rod Vagg
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

**Please be aware that this will likely be the final official release of the 0.12 release line. As per our [LTS schedule](https://github.com/nodejs/LTS/#lts-schedule), support for 0.12 ends on December 31st 2016. Please plan your migration to a newer, supported release line.**

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v0.8.6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ slug: node-v0-8-6-stable
date: 2012-08-07T19:03:55.905Z
layout: blog-post.hbs
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

2012.08.07, Version 0.8.6 (Stable)

Expand Down
4 changes: 4 additions & 0 deletions locale/en/blog/release/v4.2.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ title: Node v4.2.1 (LTS)
slug: node-v4-2-1-lts
layout: blog-post.hbs
---
<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

### Notable changes

Expand Down
5 changes: 5 additions & 0 deletions tests/scripts/CHANGELOG.fixture.legacy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Node.js v0.12 ChangeLog

<!--lint disable prohibited-strings-->
<!--lint disable maximum-line-length-->
<!--lint disable no-literal-urls-->
<!--lint disable no-shortcut-reference-link-->

<table>
<tr>
<th>Stable</th>
Expand Down