Skip to content

Conversation

@Olympicene
Copy link

added missing comma to myOptions object value

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Jan 4, 2023

Have you looked at the translated files? (There are other folders containing the same file)

edited by @ovflowd

@ovflowd

This comment was marked as off-topic.

@AugustinMauroy

This comment was marked as off-topic.

@ovflowd

This comment was marked as off-topic.

@ovflowd

This comment was marked as off-topic.

@AugustinMauroy

This comment was marked as off-topic.

Copy link

@ItaloPussi ItaloPussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking other locales, I found out that FR and PT-BR has the same mistake in the same file. Could you fix it to centralize these corrections in this pull request?

@Olympicene
Copy link
Author

Got it. Added missing commas to FR and PT-BR.

Copy link

@ItaloPussi ItaloPussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me :)

Copy link

@ItaloPussi ItaloPussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me :)

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution!!!!

Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nschonni
Copy link
Member

Thanks for the fix. Closing because #4999 was landed and removed these files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants