New Crowdin updates #4996
New Crowdin updates #4996
Conversation
| ```js | ||
| const fs = require('fs'); | ||
| const data = fs.readFileSync('/file.md'); // blocks here until file is read | ||
| const fs = require("fs"); |
There was a problem hiding this comment.
I think I most often see ''' used versus '"' so this change seems odd to me and unrelated to the translation?
The GitHub bot is already an admin in Crowdin so it should hopefully be pretty easy to make that happen. |
|
@Trott we need to resetup the integration with the GitHub account of the bot, then. I can show you how to do and you can do it if you want :) |
Is it a matter of doing https://support.crowdin.com/github-integration/ while logged in as the bot? I don't have the bot credentials, but presumably someone on @nodejs/build does..... |
|
Exactly! Just need to be logged in as the bot. |
|
Created and added a build-agenda label so this gets added to the next Build WG agenda, but hopefully it can be resolved before then (and apologies to @nodejs/build if this isn't a Build issue, but I'm guessing it is). |
This is a Build WG issue, although to set expectations, while Build does own the bot, most of @nodejs/build-infra (including myself) do not currently have access to the appropriate folder in build's secrets repository which includes the account information[1]. [1]: There's a |
|
cc @mhdawson maybe you have access to the file @richardlau is mentioning? |
|
@ovflowd we are already discussing how we get the credentials and make them accessible to the build wg, but @richardlau was setting expectations that things don't move fast and there currently is a blocking issue. |
|
Closing for now, and let's re-run the Crowdin sync after #4991 |
No description provided.