Skip to content

Conversation

xMohamd
Copy link
Contributor

@xMohamd xMohamd commented Feb 12, 2024

Description

This PR updated redirect.json

Validation

https://nodejs.org/en/docs/guides/debugging-getting-started/ => https://nodejs.org/en/learn/getting-started/debugging

https://nodejs.org/en/docs/guides/working-with-different-filesystems/ => https://nodejs.org/en/learn/manipulating-files/working-with-different-filesystems

https://nodejs.org/en/docs/guides/anatomy-of-an-http-transaction/ => https://nodejs.org/en/learn/modules/anatomy-of-an-http-transaction

https://nodejs.org/en/docs/guides/publishing-napi-modules/ => https://nodejs.org/en/learn/modules/publishing-node-api-modules

Related Issues

#6338

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@xMohamd xMohamd requested a review from a team as a code owner February 12, 2024 21:04
Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 9:16am

Signed-off-by: Claudio W <[email protected]>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Feb 14, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟠 83 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 99 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟠 83 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
85.89% (402/468) 77.16% (125/162) 77.52% (69/89)

Unit Test Report

Tests Skipped Failures Errors Time
72 0 💤 0 ❌ 0 🔥 4.585s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Feb 14, 2024
Merged via the queue into nodejs:main with commit c26ed92 Feb 14, 2024
@xMohamd xMohamd deleted the redirects branch February 14, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants