Skip to content

fix: added ellipsis for long content in breadcrumb #6794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 22, 2024
Merged

fix: added ellipsis for long content in breadcrumb #6794

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
74c6357
fix:added ellipsis for long value in breadcrumb
TenzDelek Jun 3, 2024
80aeab1
changes js to css logic
TenzDelek Jun 3, 2024
78cb692
removed double truncate
TenzDelek Jun 3, 2024
7f61f68
removed unneccesary comments and further minor changes
TenzDelek Jun 3, 2024
da325b4
Update components/Common/Breadcrumbs/BreadcrumbLink/index.module.css
ovflowd Jun 3, 2024
7ba9fa3
draft changes
TenzDelek Jun 4, 2024
80b672e
pl to px
TenzDelek Jun 4, 2024
07934dc
increase the px from 2 to 6
TenzDelek Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changes js to css logic
  • Loading branch information
@TenzDelek
TenzDelek committed Jul 21, 2024
commit 80aeab18277fd18fd7701c1290766cb5af6ffc63
2 changes: 2 additions & 0 deletions apps/site/components/Common/Breadcrumbs/BreadcrumbItem/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
.item {
@apply flex
max-w-96
items-center
gap-5
truncate
text-sm
font-medium;

Expand Down
2 changes: 2 additions & 0 deletions apps/site/components/Common/Breadcrumbs/BreadcrumbLink/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
.link {
@apply w-full truncate;

&.active {
@apply rounded
bg-green-600
Expand Down
11 changes: 1 addition & 10 deletions apps/site/components/Common/Breadcrumbs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,6 @@ const Breadcrumbs: FC<BreadcrumbsProps> = ({
const lengthOffset = maxLength - totalLength;
const isOverflow = lengthOffset < 0;

const formatLabelWithWordCount = (label: string, maxWords: number) => {
const words = label.split(' ');
if (words.length > maxWords) {
return <>{words.slice(0, maxWords).join(' ')} ...</>;
}
return label;
};
const items = useMemo(
() =>
links.map((link, index, items) => {
Expand All @@ -45,8 +38,6 @@ const Breadcrumbs: FC<BreadcrumbsProps> = ({
// We add 1 here to take into account of the truncated breadcrumb.
position <= Math.abs(lengthOffset) + 1 && isOverflow && !isLastItem;

const labelString = link.label.toString();
const formattedLabel = formatLabelWithWordCount(labelString, 6);
return (
<BreadcrumbItem
key={link.label.toString()}
Expand All @@ -55,7 +46,7 @@ const Breadcrumbs: FC<BreadcrumbsProps> = ({
position={position + +!hideHome}
>
<BreadcrumbLink href={link.href} active={isLastItem}>
<div className=" text-center">{formattedLabel}</div>
{link.label}
</BreadcrumbLink>
</BreadcrumbItem>
);
Expand Down