Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

Description

Bumping the @opennextjs/cloudflare dependency to 1.6.4, this version of the open-next adapter also supports Next.js 15.4, so I'm also removing the 15.3.2 downgrade in the CI check (introduced in #8039) 🙂

Validation

Tested this locally, also the CI check will show if this is working in CI 🙂

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Aug 4, 2025 7:22pm

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.81%. Comparing base (35f0004) to head (01ed1a2).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8065      +/-   ##
==========================================
+ Coverage   72.77%   72.81%   +0.03%     
==========================================
  Files          96       96              
  Lines        8328     8328              
  Branches      215      214       -1     
==========================================
+ Hits         6061     6064       +3     
+ Misses       2266     2263       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review August 4, 2025 19:25
Copilot AI review requested due to automatic review settings August 4, 2025 19:25
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners August 4, 2025 19:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @opennextjs/cloudflare dependency from version 1.6.2 to 1.6.4 to gain support for Next.js 15.4, and removes the temporary Next.js version downgrade from the CI workflow that was previously required due to compatibility issues.

  • Bumps @opennextjs/cloudflare dependency to version 1.6.4
  • Removes the temporary Next.js 15.3.2 downgrade step from the Playwright CI workflow

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
apps/site/package.json Updates @opennextjs/cloudflare dependency version from ^1.6.2 to ^1.6.4
.github/workflows/playwright-cloudflare-open-next.yml Removes the temporary Next.js downgrade step that forced installation of version 15.3.2
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there an update on peerDeps in @opennextjs/cloudflare to block non-compatible next versions? Though admittedly with this bump and the CI using the installed versions, a bump will get blocked by a failing CI where needed.

@dario-piotrowicz
Copy link
Member Author

Was there an update on peerDeps in @opennextjs/cloudflare to block non-compatible next versions? Though admittedly with this bump and the CI using the installed versions, a bump will get blocked by a failing CI where needed.

No sorry, no updates, I actually forgot to ask the team about that 🙇 , I'll ask right away 🙏

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@dario-piotrowicz dario-piotrowicz added the github_actions:pull-request Trigger Pull Request Checks label Aug 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟠 89 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Aug 5, 2025
Merged via the queue into nodejs:main with commit 7b15c82 Aug 5, 2025
15 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/open-next-bump-1-6-4 branch August 5, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants