Skip to content

fix: RSS button navigate to 404 page if not with en locale #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2025
Merged

fix: RSS button navigate to 404 page if not with en locale #8073

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63883cd
fix: rss button navigate to 404 page if not with en locale
kylemocode Aug 13, 2025
2c72755
fix: applied fix on link on generation
kylemocode Aug 13, 2025
9ae03dd
fix: rollback to link based solution
kylemocode Aug 15, 2025
9d78eae
chore: simplify prop usage based on type definition change on Link co…
kylemocode Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: simplify prop usage based on type definition change on Link co… 
…mponent
  • Loading branch information
@kylemocode
kylemocode committed Aug 20, 2025
commit 9d78eaee7b8529f39d54a6e435ee771f018d2777
2 changes: 1 addition & 1 deletion apps/site/components/Blog/BlogHeader/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const BlogHeader: FC<BlogHeaderProps> = ({ category }) => {
{t('layouts.blog.title')}
<Link
href={`/feed/${currentFile}`}
{...{ locale: 'en' }} // RSS feeds only exist in English
locale="en"
aria-label={t('components.blog.blogHeader.rssLink')}
>
<RssIcon />
Expand Down
Loading