-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(ui-components): throw on failed publish #8093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds error handling to the npm package publishing script to ensure failures are properly reported and handled. The change addresses an issue where the publish command could fail silently.
- Captures the return status and error from the
spawnSynccommand - Throws an error if the spawn operation itself fails
- Sets the process exit code to reflect the publish command's status
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8093 +/- ##
==========================================
+ Coverage 73.12% 73.17% +0.04%
==========================================
Files 97 97
Lines 8440 8440
Branches 229 228 -1
==========================================
+ Hits 6172 6176 +4
+ Misses 2267 2263 -4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Lighthouse Results
|
Ref: #8091 (comment)
cc @nodejs/web-infra