Skip to content

fix(fetch): improve Headers and Request type-compatibility #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(fetch): improve Headers and Request type-compatibility #1947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions types/fetch.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export declare class Headers implements SpecIterable<[string, string]> {
readonly keys: () => SpecIterableIterator<string>
readonly values: () => SpecIterableIterator<string>
readonly entries: () => SpecIterableIterator<[string, string]>
readonly [Symbol.iterator]: () => SpecIterator<[string, string]>
readonly [Symbol.iterator]: () => SpecIterableIterator<[string, string]>
Copy link
Contributor Author

@kettanaito kettanaito Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the iterator symbol on Headers must be iterable.

}

export type RequestCache =
Expand Down Expand Up @@ -146,7 +146,8 @@ export declare class Request implements BodyMixin {
readonly method: string
readonly mode: RequestMode
readonly redirect: RequestRedirect
readonly referrerPolicy: string
readonly referrer: string
Copy link
Contributor Author

@kettanaito kettanaito Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the missing referrer property.

readonly referrerPolicy: ReferrerPolicy
Copy link
Contributor Author

@kettanaito kettanaito Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also narrowing down the referrer policy as we already have the ReferrerPolicy type used for RequestInit. It cannot really be anything else, to my best knowledge.

readonly url: string

readonly keepalive: boolean
Expand Down