Skip to content

Conversation

@riderx
Copy link
Contributor

@riderx riderx commented Feb 18, 2024

This relates to tryting to contribute to the repo

I was trying to follow the guide for this PR:
#2775
And the first command to build was not working so i corrected the file with the right one

Rationale

Make easier to contribute to the repo following the guide

Changes

Only a MD file

Features

No

Bug Fixes

No

Breaking Changes and Deprecations

No

Status

@riderx
Copy link
Contributor Author

riderx commented Feb 18, 2024

I see this command exists but in the other repo, llhttp.
What doesn't make sense for the doc, since next step we need to copy wasm lib from undici.
Should both be run and my change is wrong ?

@riderx
Copy link
Contributor Author

riderx commented Feb 18, 2024

ok yes that was all command from llhttp

@riderx riderx closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant