Skip to content

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 16, 2024

USVString only expects a value parameter.

@ronag ronag requested a review from KhafraDev August 16, 2024 15:14
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think errors coming from toUSVString should match the rest of the webidl impl. Can toWellFormed throw?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 16, 2024

I dont think that toWellFormed can throw. Its basically a put any garbage in and get a valid/well formed string back.

Wdyt?

@KhafraDev
Copy link
Member

It technically can throw, but not in any way undici is using it.

String.prototype.toWellFormed.call(Symbol() / null / undefined)

@Uzlopak Uzlopak merged commit 6ee9ccd into nodejs:main Aug 16, 2024
@Uzlopak Uzlopak deleted the fix-usvstring-call branch August 16, 2024 20:17
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
@github-actions github-actions bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants