Error correction "Cannot read properties of undefined" #3825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…electFamilyAttemptedAddresses')"
Closed
mcollina
reviewed
Nov 12, 2024
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test?
|
|
||
| let s1 = null | ||
| let s2 = null | ||
| const socket = socketWeakRef.deref() |
Member
There was a problem hiding this comment.
This will keep a strong reference of the socket around, preventing its collection. Instead, deference it in the timeout.
Author
There was a problem hiding this comment.
Yes. This will prevent the error occurring in "onConnectTimeout" due to the missing socket argument.
Contributor
|
Already fixed by #3751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error correction "Cannot read properties of undefined (reading ' autoSelectFamilyAttemptedAddresses')"
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status