Skip to content

Provide access to cancelConnection so that a server can deny a client #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philips77 merged 1 commit into from
Apr 29, 2024
Merged

Provide access to cancelConnection so that a server can deny a client #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Provide access to cancelConnection so that a server can deny a device… 
… connection without creating a managed connection just to disconnect it
  • Loading branch information
@CyDragon80
CyDragon80 committed Apr 4, 2024
commit 8131257750cec18d3bea36758fec10c54b239ae8
4 changes: 3 additions & 1 deletion ble/src/main/java/no/nordicsemi/android/ble/BleServerManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,11 @@ final void useConnection(@NonNull final BluetoothDevice device, final boolean au
* <p>
* As we're not calling {@link BluetoothGattServer#connect(BluetoothDevice, boolean)}, cancelling
* the connection should not be required. On the other hand, perhaps we should call connect(..).
* Can also be called in onDeviceConnectedToServer to refuse a device connection without accepting it first.
* If you already have a managed connection and want to disconnect, you can use the disconnect request on the connection.
* @param device The device to cancel connection to.
*/
final void cancelConnection(@NonNull final BluetoothDevice device) {
protected final void cancelConnection(@NonNull final BluetoothDevice device) {
if (server != null &&
(Build.VERSION.SDK_INT < Build.VERSION_CODES.S ||
context.checkCallingOrSelfPermission(Manifest.permission.BLUETOOTH_CONNECT) == PackageManager.PERMISSION_GRANTED)) {
Expand Down