fix: remove_bond request should be handled after disconnect#571
Merged
philips77 merged 1 commit intonordicsemi:mainfrom Aug 27, 2024
Merged
fix: remove_bond request should be handled after disconnect#571philips77 merged 1 commit intonordicsemi:mainfrom
philips77 merged 1 commit intonordicsemi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is about to fix #363 case 1,
this.requestwill reset tonullin call ofnextRequest(false)below and callback forremoveBondwon't be invoked correctly even though bond status change signal is received later. how ever it may introduce unintended side effects as noted in the comment above. Please help to review it.https://github.com/NordicSemiconductor/Android-BLE-Library/blob/bfcfdf9f5916ac2b06c9de6ed335b11dc53301c2/ble/src/main/java/no/nordicsemi/android/ble/BleManagerHandler.java#L2200-L2212