Bug fix: Auto connect not restarting if the initial connection fails when using with a non-bonded device#573
Merged
philips77 merged 1 commit intonordicsemi:mainfrom Aug 16, 2024
Conversation
…connection fails without connecting first. The assumption that the device should be bonded is incorrect as autoConnect = true can be used with non-bonded devices with static addresses as well.
Contributor
|
OK, I agree. Behavior will be more predictable. |
muscardinus
deleted the
fix-auto-connect-not-restarting-if-initial-connection-fails
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using
useAutoConnect(true):the initial connection will be a normal one (calling
connectGatt()withautoConnect = false). If this fails (times out), the next connect is supposed to use auto connect (withbluetoothGatt.connect()or callingconnectGatt()withautoConnect = true).However, this does not work with a non-bonded device. As mentioned in the Javadoc of
useAutoConnect(true), auto connect is still viable to use without a bond when the BLE device has a private static address.This PR fixes the issue by removing the check for bond in the disconnected state handling.
I believe this is also the cause of this reported issue - #435