Bug fix: Cancel tasks when they are removed from the task queue#580
Merged
Bug fix: Cancel tasks when they are removed from the task queue#580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #552.
When the device gets disconnected while there are some tasks enqueued, the cancelled tasks will be notified and
.fail(...)or.invalid(...)method will be called.Also, all the tasks of a task queue (
AtomicQueueRequestorReliableWriteRequest) will be notified when they are removed from the queue (for example on disconnection, or when value validation fails during reliable write).