Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Android (Samsung S8 with Android 9) devices fail to reconnect to a device when PHY LE 2M is requested just upon connection.
This happens before service discovery is complete, but after the PHY changes to 2M. We tried with peripheral_mds sample, whcih is using bonding.
In our tests we were not able to recover and reconnect (initial connection worked fine).
After disabling PHY LE 2M on the peripheral side it started working normally on each connection.
This error is now reported as Unsupoprted Configuration (perhaps there will be more cases like that, that the Android isn't able to connect because of its own issues, now it's just the PHY).
Also
Reading and writing with invalid bond info returns error 137 (AUTH FAIL). It used to stop all requests, as
nextRequestwasn't called. Now this error goes to the regular failure handle.