Skip to content

Validation failure caused by bad formatted subject #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
norihiro wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Validation failure caused by bad formatted subject #5

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
74d822e
CI: Check commit message compliance
norihiro Aug 7, 2025
8aa9e25
A: bad commit message
norihiro Aug 7, 2025
1815585
get parent commit from gh
norihiro Aug 7, 2025
84b8821
fix exit code to fail the job
norihiro Aug 7, 2025
f8db8f1
.github: Exclude the merge commit generated by GitHub
norihiro Aug 7, 2025
40e5a34
.github: Use HEAD^1 and HEAD^2 to find the actual commits
norihiro Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
get parent commit from gh
  • Loading branch information
@norihiro
norihiro committed Aug 7, 2025
commit 18155854fbe1d1f0d5ccb82f97fa443284af92d9
8 changes: 5 additions & 3 deletions .github/actions/commit-message-validator/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ runs:

- name: Fetch commits from GitHub
shell: bash
id: gh
working-directory: ${{ inputs.workingDirectory }}
run: |
: Run log message checker
gh api repos/${{ github.repository }}/pulls/${{ github.event.number }}/commits > commits.json
: Fetch commits from GitHub
parent_commit="$(gh api repos/${{ github.repository }}/pulls/${{ github.event.number }}/commits | jq -r '.[0].parents[0].sha')"
echo "parent_commit=${parent_commit}" >> $GITHUB_OUTPUT
env:
GH_TOKEN: ${{ github.token }}

Expand All @@ -45,7 +47,7 @@ runs:
BODY_IGNORE_LINE_RE='\(^Co-Authored-By:\|\<https\?://\)'
BODY_EXCEED_LIMIT_RE='.\{73\}'

COMMIT_RANGE=master..
COMMIT_RANGE="${{ steps.gh.outputs.parent_commit }}.."

exit_code=0
export LC_ALL=C LC_CTYPE=C LANG=C
Expand Down
Loading