Added secio check back to p2p #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-libp2p replaced the NoEncryption method with the NoSecurity variable. Since the p2p tutorial still uses the secio parameter and flag, it makes sense to showcase the original. Otherwise the code becomes confusing since the secio parameter is not used anywhere, to understand this change it is necessary to browse through the closed issues, which is not that user-friendly. The alternative is to remove the secio flag and parameter all together, but this would require the blog post to be updated, while this change could also cause an update, the update is minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-libp2preplaced theNoEncryptionmethod with theNoSecurityvariable. Since the p2p tutorial still uses thesecioparameter and flag, it makes sense to showcase the original functionality. Otherwise the code becomes confusing since thesecioparameter is not used anywhere, to understand this change it is necessary to browse through the closed issues, which is not that user-friendly. The alternative is to remove thesecioflag and parameter all together, but this would require the blog post to be updated, while this change could also cause an update, the update is minimal.