Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing indentation
  • Loading branch information
vitorpamplona committed Jun 12, 2023
commit 22c1af86227ea09c15fbcc6d34bf14711847e4e4
10 changes: 5 additions & 5 deletions 172.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ Kind 34550 should include any field that helps define the community and the set
"kind": "34550",
"tags": [
["d", "<community_name>"],
["description", "<community_description>"],
["description", "<community_description>"],

// moderators
["p", "<32-bytes hex of a pubkey>", "<optional recommended relay URL>", "moderator"]
["p", "<32-bytes hex of a pubkey>", "<optional recommended relay URL>", "moderator"]
["p", "<32-bytes hex of a pubkey>", "<optional recommended relay URL>", "moderator"]
["p", "<32-bytes hex of a pubkey>", "<optional recommended relay URL>", "moderator"]
["p", "<32-bytes hex of a pubkey>", "<optional recommended relay URL>", "moderator"]
]
}
```
Expand Down Expand Up @@ -61,8 +61,8 @@ The post-approval event includes a stringified `new post request` event inside t
"kind": "34551",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameterized replaceable event is missing a "d" tag. Considering the user can be a moderator on many communities and may approve the same event id for more than one group, i think it would be this giant string: ["d", "34550:<community event author pubkey>:<d-identifier of the community>:<Post Request ID>"].

Maybe it is better as a regular event in the 1000 <= n < 10000 range like 4550 or 4551 with no "d" tag. I don't know.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I think we can move it to a regular event with event deletion to revert things.

"tags": [
["a", "34550:<community event author pubkey>:<d-identifier of the community>", "<optional relay url>"],
["e", "<Post Request ID>", "<optional relay url>"],
["p", "<Post Request Author ID>", "<optional relay url>"],
["e", "<Post Request ID>", "<optional relay url>"],
["p", "<Post Request Author ID>", "<optional relay url>"],
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
],
["!", "<Community event author pubkey>"],
],

This would use #539 to make the community owner able to delete post approvals created by others (moderators).

Currently the owner can only delete its own approvals or remove moderators (which deletes all approvals from said moderator).

"content": "{ <New Post Request JSON> }"
}
Expand Down