-
Notifications
You must be signed in to change notification settings - Fork 721
Nip07 - add nip44 #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nip07 - add nip44 #922
Conversation
|
This is already part of the NIP 44 PR: https://github.com/nostr-protocol/nips/pull/746/files |
|
ah cool thanks. should we add getKey for nip44 too? |
|
I'm personally against it, I don't think it accomplishes anything that a well-optimized nip 07 extension can't. |
|
Get key should be available on the Android Signer and the NIP-46 Signers. I think we should add to nip-07 just for consistency in case somebody is making a single app that uses all of the 3 signers at the same time. |
|
+1 I'm with @vitorpamplona ; consistency is good and you can drive a truck through "well-optimized nip07 extension" 😅 |
|
I have reopened this in a new PR (github wasn't letting me reopen this one) #940 NIP07 updates were removed from NIP44 PR so opening this again to come to agreement on how nip07 should be updated |
|
I haven't been able to track all the changes to this file and NIP 46 that have been proposed, what's the argument for Edit, ignore this, I'll re-post in the real PR. |
add nip44 calls to NIP07 spec
https://github.com/monlovesmango/nips/blob/NIP07-Add-nip44/07.md