Skip to content

fix(dashboard): Override defaults toggle save fixes NV-7112#10018

Merged
scopsy merged 1 commit intonextfrom
cursor/override-defaults-toggle-save-f6ea
Feb 13, 2026
Merged

fix(dashboard): Override defaults toggle save fixes NV-7112#10018
scopsy merged 1 commit intonextfrom
cursor/override-defaults-toggle-save-f6ea

Conversation

@djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

The "Override code defined defaults" toggle in custom-step-controls.tsx was not triggering a save action when switched ON, causing the change to not persist. This PR adds a call to saveForm({ forceSubmit: true }); when the toggle is enabled to ensure the state is correctly saved.

Screenshots

N/A


Slack Thread

Open in Cursor Open in Web

Co-authored-by: George Djabarov <djabarovgeorge@users.noreply.github.com>
@cursor
Copy link
Contributor

cursor bot commented Feb 12, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@netlify
Copy link

netlify bot commented Feb 12, 2026

Deploy preview added

Name Link
🔨 Latest commit c6bb621
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/698de7c1b9c5270008265afe
😎 Deploy Preview https://deploy-preview-10018.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@scopsy scopsy changed the title Override defaults toggle save fix(dashboard): Override defaults toggle save fixes fixes NV-7112 Feb 13, 2026
@linear
Copy link

linear bot commented Feb 13, 2026

@scopsy scopsy marked this pull request as ready for review February 13, 2026 07:20
@scopsy scopsy changed the title fix(dashboard): Override defaults toggle save fixes fixes NV-7112 fix(dashboard): Override defaults toggle save fixes NV-7112 Feb 13, 2026
@scopsy scopsy merged commit 5a814b2 into next Feb 13, 2026
29 of 32 checks passed
@scopsy scopsy deleted the cursor/override-defaults-toggle-save-f6ea branch February 13, 2026 07:21
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The CustomStepControls component in the workflow editor has been modified to invoke saveForm({ forceSubmit: true }) when the override toggle is switched on. Previously, saveForm was only called when disabling the override. This change adds a form save operation to the toggle-on flow, adding one line of code with no modifications to public signatures or exports.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants