fix(dashboard): Allow null controlValues and update restore behavior fixrs NV-7112 fixes NV-7112

[scopsy]

Treat controlValues === undefined as the only case to keep existing values (so null is now accepted) in updateStepInWorkflow. In the custom step controls component, import and use updateStepInWorkflow and workflow.update; when restoring defaults reset the form and update the workflow with controlValues: null (instead of calling saveForm). Add a guard for missing workflow/step and visually disable the JSON form when the controls are not overridden.

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

[linear]

NV-7112 Override code defined defaults toggle doesn’t save on enable

[netlify]

✅ Deploy Preview for dashboard-v2-novu-staging ready!

Name	Link
🔨 Latest commit	838a87c
🔍 Latest deploy log	https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/6991c1dacb4dc20008498ba2
😎 Deploy Preview	https://deploy-preview-10037.dashboard-v2.novu-staging.co
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

✅ PR title automatically updated!

I found the Linear ticket ID fix(dashboard): Allow null controlValues and update restore behavior fixrs NV-7112 fixes NV-7112 in your branch name and automatically added it to your PR title.

Updated title: fix(dashboard): Allow null controlValues and update restore behavior fixrs NV-7112 fixes NV-7112

[coderabbitai]

Walkthrough

This change refactors how the workflow editor handles step control value updates. The updateStepInWorkflow function now uses explicit undefined checks instead of truthiness evaluation when merging control values, allowing falsy values to be preserved. Additionally, the custom step controls component is updated to use the workflow update mechanism instead of direct form saving, with added logic to disable the form based on override state and improved handling of default value restoration.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions allowing null controlValues and updating restore behavior, which aligns with the main changes, but contains a typo ('fixrs' instead of 'fixes') and is somewhat unclear due to the malformed text at the end.	Correct the typo and clarify the title. Consider: 'fix(dashboard): Allow null controlValues in workflow steps and update restore behavior' or similar.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description clearly explains what changed: updating controlValues behavior to accept null, importing updateStepInWorkflow, changing restore defaults flow, and adding guards/visual disabling of the form.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into next

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}