Skip to content

fix(dashboard): Forward readonly and disabled to VariableInput#10048

Merged
scopsy merged 2 commits intonextfrom
fix-disabled-state-
Feb 16, 2026
Merged

fix(dashboard): Forward readonly and disabled to VariableInput#10048
scopsy merged 2 commits intonextfrom
fix-disabled-state-

Conversation

@scopsy
Copy link
Contributor

@scopsy scopsy commented Feb 16, 2026

Pass readOnly and disabled props to the VariableInput in TextWidget so the control respects the parent readonly/disabled state. This makes the text widget non-editable or disabled when the surrounding step or form is marked readonly/disabled.

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Pass readOnly and disabled props to the VariableInput in TextWidget so the control respects the parent readonly/disabled state. This makes the text widget non-editable or disabled when the surrounding step or form is marked readonly/disabled.
@netlify
Copy link

netlify bot commented Feb 16, 2026

Deploy preview added

Name Link
🔨 Latest commit 58deb8f
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/69930c8a1c8c20000769c25d
😎 Deploy Preview https://deploy-preview-10048.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted.

Your PR title is: fix(dashboard): Forward readonly and disabled to VariableInput

Requirements:

  1. Follow the Conventional Commits specification
  2. As a team member, include Linear ticket ID at the end: fixes TICKET-ID or include it in your branch name

Expected format: feat(scope): Add fancy new feature fixes NOV-123

Details:

PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

The patch adds a readOnly prop path through text input components and propagates existing readonly/disabled flags to underlying editors: ControlInput now accepts and forwards readOnly to VariableEditor, VariableEditor gains a readOnly prop and computes editable as !disabled && !readOnly, and the non-number branch in TextWidget passes readOnly/disabled into ControlInput. Separately, a pre-check that aborted processing when an organization did not exist was removed from a worker handler.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: forwarding readonly and disabled props to VariableInput in TextWidget to respect parent state.
Description check ✅ Passed The description explains the purpose of the changes and relates to the changeset, specifically addressing how readonly/disabled props are propagated.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into next

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Introduce an optional readOnly prop to VariableEditor and ControlInput (default false) and wire it through so editors respect readOnly (VariableEditor editable now false when readOnly). Also remove the organization existence check and early-return/log in SubscriberProcessWorker, so jobs are no longer skipped based on that check.
@scopsy scopsy merged commit 3e673c6 into next Feb 16, 2026
28 of 29 checks passed
@scopsy scopsy deleted the fix-disabled-state- branch February 16, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant