Skip to content

fix(api-service): Make billing address required fixes NV-7065#9872

Merged
scopsy merged 4 commits intonextfrom
nv-7065-make-state-field-required-if-country-is-us
Jan 22, 2026
Merged

fix(api-service): Make billing address required fixes NV-7065#9872
scopsy merged 4 commits intonextfrom
nv-7065-make-state-field-required-if-country-is-us

Conversation

@scopsy
Copy link
Contributor

@scopsy scopsy commented Jan 20, 2026

Advanced the .source submodule reference to commit c7d89e794b1a7bc0cca190b26fb085f4248a6568 to incorporate recent changes from the submodule.

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Advanced the .source submodule reference to commit c7d89e794b1a7bc0cca190b26fb085f4248a6568 to incorporate recent changes from the submodule.
@linear
Copy link

linear bot commented Jan 20, 2026

@netlify
Copy link

netlify bot commented Jan 20, 2026

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit 6540056
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/6971d81a62d52000089f4f6e

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Walkthrough

The subproject commit reference was updated from fa0f8fbdc5af126e2b3f8405684e72f3b72b4e4f to c8a17f76b340688d8ccebe8f9e513ef190ed529b. Two end-to-end test files (apps/api/src/app/billing/e2e/checkout-session-completed.e2e-ee.ts and apps/api/src/app/billing/e2e/create-checkout-session.e2e-ee.ts) were modified to change the mocked Stripe checkout session parameter billing_address_collection from auto to required. No other code, public API, control flow, or error handling changes were made.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description mentions advancing the .source submodule reference but omits crucial details about the actual billing address requirement changes made in the test files. Clarify what 'make billing address required' means and why it was necessary. Explain the relationship between the submodule change and the test file modifications.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: making billing address required to fix issue NV-7065, which aligns with the billing_address_collection updates in the test files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Updated e2e test mocks to use 'required' for billing_address_collection instead of 'auto' in checkout session creation and completion event tests. This ensures tests reflect the intended requirement for billing address collection.
@scopsy scopsy merged commit 1666436 into next Jan 22, 2026
29 checks passed
@scopsy scopsy deleted the nv-7065-make-state-field-required-if-country-is-us branch January 22, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant