fix(api-service): Subscriber inactive channels default

[scopsy]

What changed? Why was the change needed?

The includeInactiveChannels parameter in the GET /:subscriberId/preferences/global endpoint was changed to true by default. This change was requested to ensure inactive channels are included by default when fetching global preferences.

Screenshots

---

Slack Thread

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[netlify]

✅ Deploy Preview for dashboard-v2-novu-staging canceled.

Name	Link
🔨 Latest commit	dc9ce3c
🔍 Latest deploy log	https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/6970a8b47241850008f89510

[github-actions]

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted.

Your PR title is: fix(api-service): Subscriber inactive channels default

Requirements:

1. Follow the Conventional Commits specification
2. As a team member, include Linear ticket ID at the end: fixes TICKET-ID or include it in your branch name

Expected format: feat(scope): Add fancy new feature fixes NOV-123

Details:

PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name

[coderabbitai]

Walkthrough

A parameter in the SubscribersController's getGlobalPreference method was modified to change the behavior of global preference retrieval. The includeInactiveChannels parameter passed to GetSubscriberGlobalPreferenceCommand.create was changed from false to true. This alteration affects which channels are included when fetching subscriber global preferences. The overall control flow and other parameters of the operation remain unchanged. No exported entity signatures were modified.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: modifying the default behavior of the includeInactiveChannels parameter in the subscribers controller.
Description check	✅ Passed	The description is directly related to the changeset, explaining the rationale for changing includeInactiveChannels to true and referencing relevant discussions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/api/src/app/subscribers-v2/subscribers.controller.ts (1)

279-293: Behavioral change hardcoded: include all inactive channels by default.

This endpoint is the only caller that hardcodes includeInactiveChannels: true, while all other usages (including in get-subscriber-preferences, get-inbox-preferences, and inbox.controller) default to false. Verify SDK consumers are aware of this change in behavior—the endpoint is excluded from API docs (@ApiExcludeEndpoint()) but is exposed via SDK method name, so this constitutes a breaking change for SDK consumers expecting inactive channels to be excluded.