Skip to content

fix(api-service): Update includeInactiveChannels defaults in subscribers v1 controllers#9889

Merged
scopsy merged 1 commit intonextfrom
fix-default-channels-v1-api
Jan 22, 2026
Merged

fix(api-service): Update includeInactiveChannels defaults in subscribers v1 controllers#9889
scopsy merged 1 commit intonextfrom
fix-default-channels-v1-api

Conversation

@scopsy
Copy link
Contributor

@scopsy scopsy commented Jan 22, 2026

Changed the default value of includeInactiveChannels to false in subscribers-v2 controller and to true in subscribersV1 controller to align with updated requirements for channel inclusion.

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Changed the default value of includeInactiveChannels to false in subscribers-v2 controller and to true in subscribersV1 controller to align with updated requirements for channel inclusion.
@netlify
Copy link

netlify bot commented Jan 22, 2026

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit bce92fb
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/69722d8ce8177c0008b142d2

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

Walkthrough

This pull request modifies the handling of inactive channels across two controller endpoints in the subscribers module. In the v2 controller, the getGlobalPreference method now excludes inactive channels when executing the related command (changed from true to false). Conversely, in the v1 controller, the GetSubscriberPreferenceByLevel endpoint now includes inactive channels by default (changed from false to true). Both changes are parameter-level modifications that alter channel inclusion behavior without affecting other logic or error handling paths.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating includeInactiveChannels defaults in subscribers controllers, matching the actual modifications across both v1 and v2 controller files.
Description check ✅ Passed The description is related to the changeset, explaining the default value changes and their purpose, though it lacks specific context about why these changes align with updated requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scopsy scopsy merged commit 05e7979 into next Jan 22, 2026
26 of 30 checks passed
@scopsy scopsy deleted the fix-default-channels-v1-api branch January 22, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant