This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Isaacs/filtered reification #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Found some bugs exploring the edge cases around this. Have fixes for them, but don't yet have tests for all the fixes. |
This causes major problems when moving links and targets between trees. When we move the link from one tree to another, it pulls its target, out, meaning that the target ends up becoming orphaned. Say there is a matching link and target in two different trees, A and B, and we want to replace the link and target in one tree with the link and target in another. If we move the target A to tree B first, then it replaces the target B, and link B is updated to point to it. Then, we move link A to tree B, replacing link B. To do that, we move link B out of tree B, which _takes target B with it_, leaving the ported link A without a target in tree B.
This also corrects an issue where manually updating the package.json file would sometimes not be reified properly, if a new link target matches the one that was formerly reified.
isaacs
force-pushed
the
isaacs/filtered-reification
branch
from
ce3f818 to
a8a1e84
Compare
Fixes sorting incorrectly when a dependency is set to an empty string
nlf
approved these changes
Mar 31, 2021
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
followed the changes well enough to see what's going on, tests told the rest of the story. i think this makes sense!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
workspacesarray of names passed to the Arborist constructor, which will limit reification to only those workspace nodes and their graph of dependencies.Also, uses the filtered Diff behavior to ensure that global installs only make changes within the specific paths indicated by the set of explicit requests (which should be happening anyway, but which has been a bit of a bug factory in the past).
Open to bike shedding on the option name, it is a bit confusing, since it isn't the map of nodes loaded by
mapWorkspaces, but I wasn't sure what other way to make the reify call more clear.