Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Conversation

@mikemimik
Copy link
Contributor

@mikemimik mikemimik commented Dec 6, 2019

What / Why

References

@mikemimik
Copy link
Contributor Author

Interesting Finding:

  • Found weird issue with someones when creating a pull-request the commit_sha doesn't get set with the curl request. I think this is because of the ${{ github.event.after }} is not always what we think it will be. First invocation of the pull_request event type seems to have this property missing.

@mikemimik mikemimik mentioned this pull request Dec 19, 2019
3 tasks
@mikemimik mikemimik merged commit 55b70b1 into master Dec 19, 2019
@wraithgar wraithgar deleted the feature/results-threshold branch August 31, 2021 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant