Skip to content

Fix install with local modules under multiple paths #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix install with local modules under multiple paths #217

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2de13b8
Add (failing) test for failing relative paths
salomvary Jul 22, 2019
96449a1
Revert "inflate-shrinkwrap: Stop shortcircuiting tree walks with fake…
salomvary Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "inflate-shrinkwrap: Stop shortcircuiting tree walks with fake… 
… children"

This reverts commit 2f0c883 to fix
https://npm.community/t/installing-the-same-module-under-multiple-relative-paths-fails-on-linux/8863
  • Loading branch information
@salomvary
salomvary committed Jul 22, 2019
commit 96449a11b338de6f648dfd46acf5e2de74e2dab0
2 changes: 1 addition & 1 deletion lib/install/inflate-shrinkwrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function makeFakeChild (name, topPath, tree, sw, requested) {
}
const child = createChild({
package: pkg,
loaded: false,
loaded: true,
parent: tree,
children: [],
fromShrinkwrap: requested,
Expand Down