Skip to content

fix: publish --dry-run require login & publishConfig loaded after registry check #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nlf merged 3 commits into from
Jan 28, 2021
Merged

fix: publish --dry-run require login & publishConfig loaded after registry check #2445

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1bea2f
test: publish: test add read registry only from publishConfig
dr-js Jan 8, 2021
938a77d
fix: publish: delay registry & login check till publishConfig merge
dr-js Jan 8, 2021
d2f8af2
fix: publish: test defaultTag caused early error
dr-js Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: publish: delay registry & login check till publishConfig merge
  • Loading branch information
@dr-js @nlf
dr-js authored and nlf committed Jan 28, 2021
commit 938a77d6e7fb79f8ceb72c51bf06e27127fb9f06
33 changes: 17 additions & 16 deletions lib/publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,7 @@ const publish = async args => {
log.verbose('publish', args)

const opts = { ...npm.flatOptions }
const { json, defaultTag, registry } = opts

if (!registry) {
throw Object.assign(new Error('No registry specified.'), {
code: 'ENOREGISTRY',
})
}

if (!opts.dryRun) {
const creds = npm.config.getCredentialsByURI(registry)
if (!creds.token && !creds.username) {
throw Object.assign(new Error('This command requires you to be logged in.'), {
code: 'ENEEDAUTH',
})
}
}
const { json, defaultTag } = opts

if (semver.validRange(defaultTag))
throw new Error('Tag name must not be a valid SemVer range: ' + defaultTag.trim())
Expand Down Expand Up @@ -91,6 +76,22 @@ const publish_ = async (arg, opts) => {
if (manifest.publishConfig)
Object.assign(opts, publishConfigToOpts(manifest.publishConfig))

const { registry } = opts
if (!registry) {
throw Object.assign(new Error('No registry specified.'), {
code: 'ENOREGISTRY',
})
}

if (!dryRun) {
const creds = npm.config.getCredentialsByURI(registry)
if (!creds.token && !creds.username) {
throw Object.assign(new Error('This command requires you to be logged in.'), {
code: 'ENEEDAUTH',
})
}
}

// only run scripts for directory type publishes
if (spec.type === 'directory') {
await runScript({
Expand Down