Skip to content

cli: don't check for updates to npm when we are updating npm itself #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zkat merged 2 commits into from
Aug 3, 2018
Merged

cli: don't check for updates to npm when we are updating npm itself #32

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f801d8
doc: file-specifier: Remove stray comment
iarna Jul 26, 2018
d905508
cli: don't check for updates to npm when we are updating npm itself
olore Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: file-specifier: Remove stray comment
  • Loading branch information
@iarna
iarna authored Jul 26, 2018
commit 4f801d8a476f7ca52b0f182bf4e17a80db12b4e2
3 changes: 0 additions & 3 deletions doc/spec/file-specifiers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ note for the `npm-shrinkwrap.json` as it means the specifier there will
be different then the original `package.json` (where it was relative to that
`package.json`).

# No, for `file:` type specifiers, we SHOULD shrinkwrap. Other symlinks we
# should not. Other symlinks w/o the link spec should be an error.

When shrinkwrapping file specifiers, the contents of the destination
package's `node_modules` WILL NOT be included in the shrinkwrap. If you want to lock
down the destination package's `node_modules` you should create a shrinkwrap for it
Expand Down