Skip to content

feat(config): warn on deprecated configs #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fritzy merged 2 commits into from
Apr 13, 2022
Merged

feat(config): warn on deprecated configs #4740

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f5b986
feat(config): warn on deprecated configs
lukekarrys Apr 13, 2022
42d2db6
deps: @npmcli/[email protected]
lukekarrys Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps: @npmcli/[email protected]
  • Loading branch information
@lukekarrys
lukekarrys committed Apr 13, 2022
commit 42d2db6e7d9740439e0046fb0b2ff0b98b1d6e05
5 changes: 2 additions & 3 deletions node_modules/@npmcli/config/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,10 +506,9 @@ class Config {
}

[_checkDeprecated] (key, where, obj, kv) {
// XXX a future npm version will make this a warning.
// An even more future npm version will make this an error.
// XXX(npm9+) make this throw an error
if (this.deprecated[key]) {
log.verbose('config', key, this.deprecated[key])
log.warn('config', key, this.deprecated[key])
}
}

Expand Down
6 changes: 3 additions & 3 deletions node_modules/@npmcli/config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@npmcli/config",
"version": "4.0.2",
"version": "4.1.0",
"files": [
"bin/",
"lib/"
Expand Down Expand Up @@ -31,7 +31,7 @@
},
"devDependencies": {
"@npmcli/eslint-config": "^3.0.1",
"@npmcli/template-oss": "3.2.2",
"@npmcli/template-oss": "3.3.2",
"tap": "^16.0.1"
},
"dependencies": {
Expand All @@ -49,6 +49,6 @@
},
"templateOSS": {
"//@npmcli/template-oss": "This file is partially managed by @npmcli/template-oss. Edits may be overwritten.",
"version": "3.2.2"
"version": "3.3.2"
}
}
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"@isaacs/string-locale-compare": "^1.1.0",
"@npmcli/arborist": "^5.0.4",
"@npmcli/ci-detect": "^2.0.0",
"@npmcli/config": "^4.0.2",
"@npmcli/config": "^4.1.0",
"@npmcli/fs": "^2.1.0",
"@npmcli/map-workspaces": "^2.0.2",
"@npmcli/package-json": "^2.0.0",
Expand Down Expand Up @@ -858,9 +858,9 @@
}
},
"node_modules/@npmcli/config": {
"version": "4.0.2",
"resolved": "https://registry.npmjs.org/@npmcli/config/-/config-4.0.2.tgz",
"integrity": "sha512-UqD4h4LgyNOb7xRmAK7QXiMu0/k2x7wEzrEqXZ1wGIQVmCl3vamsAprDjAhi7IKlgRulg09hpwYs2/57OP22xw==",
"version": "4.1.0",
"resolved": "https://registry.npmjs.org/@npmcli/config/-/config-4.1.0.tgz",
"integrity": "sha512-cPQmIQ2Q0vuOfrenrA3isikdMFMAHgzlXV+EmvZ8f2JeJsU5xTU2bG7ipXECiMvPF9nM+QDnMLuIg8QLw9H4xg==",
"inBundle": true,
"dependencies": {
"@npmcli/map-workspaces": "^2.0.2",
Expand Down Expand Up @@ -10504,9 +10504,9 @@
"version": "2.0.0"
},
"@npmcli/config": {
"version": "4.0.2",
"resolved": "https://registry.npmjs.org/@npmcli/config/-/config-4.0.2.tgz",
"integrity": "sha512-UqD4h4LgyNOb7xRmAK7QXiMu0/k2x7wEzrEqXZ1wGIQVmCl3vamsAprDjAhi7IKlgRulg09hpwYs2/57OP22xw==",
"version": "4.1.0",
"resolved": "https://registry.npmjs.org/@npmcli/config/-/config-4.1.0.tgz",
"integrity": "sha512-cPQmIQ2Q0vuOfrenrA3isikdMFMAHgzlXV+EmvZ8f2JeJsU5xTU2bG7ipXECiMvPF9nM+QDnMLuIg8QLw9H4xg==",
"requires": {
"@npmcli/map-workspaces": "^2.0.2",
"ini": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@isaacs/string-locale-compare": "^1.1.0",
"@npmcli/arborist": "^5.0.4",
"@npmcli/ci-detect": "^2.0.0",
"@npmcli/config": "^4.0.2",
"@npmcli/config": "^4.1.0",
"@npmcli/fs": "^2.1.0",
"@npmcli/map-workspaces": "^2.0.2",
"@npmcli/package-json": "^2.0.0",
Expand Down