Use https when possible. #7
Conversation
|
So, this needs the node-semver PR first merged, released and the lib updated here for tests to pass. Let me know how to proceed. |
|
PR rebased and removed the node-semver changes; when the package is updated any changes will be picked up. |
changelogs/CHANGELOG-2.md
Outdated
| *Sighs audibly.* | ||
|
|
||
| [Let us know](http://github.com/npm/npm/issues/new) if we broke something else | ||
| [Let us know](https://github.com/npm/npm/issues/new) if we broke something else |
There was a problem hiding this comment.
Should this be https://github.com/npm/cli/issues/new
There was a problem hiding this comment.
Probably but not related to the https change :P
There was a problem hiding this comment.
heh, looks like both the link to npm/npm issues and the link to npm/cli issues are actually broken.
Looks like npm/cli moved their issues to Discourse. Maybe the #support or #bugs categories would be appropriate here.
There was a problem hiding this comment.
Because the old repo has been archived...
I can fix this one, np.
There was a problem hiding this comment.
There are thousands of old links that could be updated. The commit ones should be safe to do since the hashes should be the same. PR/issue links should stay. And changelog.js needs to be updated.
changelogs/CHANGELOG-3.md
Outdated
| Here are the issues that we already know about. If you run into something | ||
| that isn't on this list, | ||
| [let us know](https://github.com/npm/npm/issues/new)! | ||
| [let us know](https://github.com/npm/cli/issues/new)! |
There was a problem hiding this comment.
Ah, looks like this is a broken link also, because npm/cli moved their issues to Discourse.
Maybe the #support or #bugs categories would be appropriate here.
cc @zkat
There was a problem hiding this comment.
No need to modify this file at all. Please leave this as-is for historical purposes.
zkat
left a comment
zkat
left a comment
There was a problem hiding this comment.
I appreciate the time taken to change links to https, but I have some requests for this particular one:
I don't think we should be changing most of these URLs at all. I've gone through and marked the ones that I think are worth keeping, but I think the others should be reverted.
Usually, when I get a big diff like this, I prefer making sure the diff is actually adding significant value. Just doing a sweeping search-and-replace is relatively low-value when you look at the actual URLs, and in general, I'd much prefer to keep certain things intact.
changelogs/CHANGELOG-2.md
Outdated
|
|
||
| There's a very important bug fix and a long-awaited (and significant!) | ||
| deprecation in this hotfix release. [Hold on.](http://butt.holdings/) | ||
| deprecation in this hotfix release. [Hold on.](https://butt.holdings/) |
There was a problem hiding this comment.
I would rather not modify archived changelogs.
changelogs/CHANGELOG-3.md
Outdated
|
|
||
| There are two very important bug fixes and one long-awaited (and significant!) | ||
| deprecation in this hotfix release. [Hold on.](http://butt.holdings/) | ||
| deprecation in this hotfix release. [Hold on.](https://butt.holdings/) |
There was a problem hiding this comment.
Ditto this changelog. Please leave this as-is.
changelogs/CHANGELOG-3.md
Outdated
| Here are the issues that we already know about. If you run into something | ||
| that isn't on this list, | ||
| [let us know](https://github.com/npm/npm/issues/new)! | ||
| [let us know](https://github.com/npm/cli/issues/new)! |
There was a problem hiding this comment.
No need to modify this file at all. Please leave this as-is for historical purposes.
changelogs/CHANGELOG-4.md
Outdated
| [#15833](https://github.com/npm/npm/pull/15833) | ||
| Mention the [24-hour unpublish | ||
| policy](http://blog.npmjs.org/post/141905368000/changes-to-npms-unpublish-policy) | ||
| policy](https://blog.npmjs.org/post/141905368000/changes-to-npms-unpublish-policy) |
There was a problem hiding this comment.
Ditto for not modifying changelogs.
changelogs/CHANGELOG-5.md
Outdated
|
|
||
| `npm ci` is, right now, [the fastest | ||
| installer](http://blog.npmjs.org/post/171556855892/introducing-npm-ci-for-faster-more-reliable) | ||
| installer](https://blog.npmjs.org/post/171556855892/introducing-npm-ci-for-faster-more-reliable) |
| possible, and not to lock it down to specific patch versions. | ||
|
|
||
| Assuming the host complies with [semver](http://semver.org/), only changes in | ||
| Assuming the host complies with [semver](https://semver.org/), only changes in |
| using a confusingly similar package name, email <[email protected]> with a link to | ||
| the package or user account on [https://npmjs.com](https://npmjs.com). Attach a | ||
| copy of your trademark registration certificate. | ||
| the package or user account on [https://www.npmjs.com/](https://www.npmjs.com/). |
| ## Is there a website or something to see package docs and such? | ||
|
|
||
| Yes, head over to <https://npmjs.com/> | ||
| Yes, head over to <https://www.npmjs.com/> |
| <h1>npm</h1> | ||
|
|
||
| <p>npm is a package manager for <a href="http://nodejs.org/">node</a>. You can use it to install | ||
| <p>npm is a package manager for <a href="https://nodejs.org/">node</a>. You can use it to install |
| # | ||
| # See this helpful document on writing portable shell scripts: | ||
| # http://www.gnu.org/s/hello/manual/autoconf/Portable-Shell.html | ||
| # https://www.gnu.org/s/hello/manual/autoconf/Portable-Shell.html |
|
@zkat please check again. |
4 participants
Also, fix a few redirects.
Related PRs: