Skip to content

chore: Improve link accessibility for screen reader users #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

chore: Improve link accessibility for screen reader users #8604

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab39380
docs(link): configuring third-party registries
jsoref Sep 28, 2025
846d95f
docs(link): File a ticket
jsoref Sep 28, 2025
fb8fe8f
chore(link): Test
jsoref Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(link): Test 
Signed-off-by: Josh Soref <[email protected]>
  • Loading branch information
@jsoref
jsoref committed Sep 29, 2025
commit fb8fe8fdf7ee7b0da76c73f19625e373e67d85ca
2 changes: 1 addition & 1 deletion docs/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ t.test('html', async t => {
// but we test for coverage
t.test('files can link to root pages', async t => {
await testBuildDocs(t, {
content: { 'test.md': '[link](/test)' },
content: { 'test.md': '[Test](/test)' },
Copy link
Contributor Author

@jsoref jsoref Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is a test as opposed to something that's read by a real user/screen reader, but people have a tendency to copy and paste from tests -- treating them as sample code, so unless there's a good reason not to fix a test, I prefer to offer a fix for it too.

Copy link
Member

@wraithgar wraithgar Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, you're 100% right fixing even these.

nav: '- url: /test',
})
})
Expand Down
Loading