Skip to content

Conversation

@wujunchuan
Copy link

Most implementations only support having one property with a given name in a section. But some programs use duplicate property names to implement multi-valued properties.

If the ini library can compatible this feature, it will improve compatible with difference scenes. It all depends on the developer needs.

This PR include these change about:

  • handle duplicate property as array
  • add new options.withoutArraySuffix:boolean for encode method to decide output array include [] suffix or not
    default is false and will work just like before
  • add test/duplicate-properties.js for 100% coverage test

References

Wikipedia about INI file description in varying features:
Wikipedia - INI file

@wujunchuan
Copy link
Author

wujunchuan commented Nov 28, 2020

/home/travis/build/npm/ini/node_modules/tap/node_modules/stack-utils/index.js:51
  clean (stack, indent = 0) {
                       ^
SyntaxError: Unexpected token = xxxxx

This seems to be a compatibility issue with the test library tap in Nodejs@4(default argument value feature)

@chapterjason
Copy link

@wujunchuan are you still working on this feature?

@wujunchuan
Copy link
Author

@wujunchuan are you still working on this feature?

No, as it seems that the repo is not maintained anymore.

But if you need this feature, you can fork my repo.

@Leask
Copy link

Leask commented Nov 10, 2021

I fixed all issues and made a new pr: #137, please review :)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0

@wraithgar
Copy link
Member

Closing for #137

@wraithgar wraithgar closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants