Skip to content

fix: residual space after section causes bad parsing #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wraithgar wants to merge 2 commits into from
Closed

fix: residual space after section causes bad parsing #203

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac1ce69
fix: residual space after section causes bad parsing
Nautigsam Mar 4, 2021
6949c30
fixup! fix: residual space after section causes bad parsing
wraithgar Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ini.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ const decode = str => {
const out = Object.create(null)
let p = out
let section = null
// section |key = value
const re = /^\[([^\]]*)\]$|^([^=]+)(=(.*))?$/i
// section |key = value
const re = /^\[([^\]]*)\].*$|^([^=]+)(=(.*))?$/i
const lines = str.split(/[\r\n]+/g)

for (const line of lines) {
Expand Down
1 change: 1 addition & 0 deletions tap-snapshots/test/foo.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Null Object {
"three",
"this is included",
],
"b": Null Object {},
"br": "warm",
"eq": "eq=eq",
"false": false,
Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/foo.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ j = "{ o: "p", a: { av: "a val", b: { c: { e: "this [value]" } } } }"
cr[] = four
cr[] = eight

; b section with a space after its title
[b]

; nested child without middle parent
; should create otherwise-empty a.b
[a.b.c]
Expand Down