Skip to content

fix: check process on browser #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wraithgar merged 5 commits into from
May 15, 2023
Merged

fix: check process on browser #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4ff44f
fix: check process on browser
Creskendoll May 4, 2023
e01d376
revert format
Creskendoll May 4, 2023
408bbe5
avoid ternery
Creskendoll May 4, 2023
41c2f49
lintfix
Creskendoll May 4, 2023
2f3b1ad
test coverage
Creskendoll May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/ini.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ const encode = (obj, opt = {}) => {
opt.newline = opt.newline === true
opt.sort = opt.sort === true
opt.whitespace = opt.whitespace === true || opt.align === true
// The `typeof` check is required because accessing the `process` directly fails on browsers.
/* istanbul ignore next */
opt.platform = opt.platform || process?.platform
opt.platform = opt.platform || (typeof process !== 'undefined' && process.platform)
opt.bracketedArray = opt.bracketedArray !== false

/* istanbul ignore next */
Expand Down Expand Up @@ -172,8 +173,8 @@ const decode = (str, opt = {}) => {
const remove = []
for (const k of Object.keys(out)) {
if (!hasOwnProperty.call(out, k) ||
typeof out[k] !== 'object' ||
Array.isArray(out[k])) {
typeof out[k] !== 'object' ||
Array.isArray(out[k])) {
continue
}

Expand Down
10 changes: 10 additions & 0 deletions tap-snapshots/test/foo.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,3 +292,13 @@ label = debug
value = 10

`

exports[`test/foo.js TAP encode within browser context > must match snapshot 1`] = `
[log]
type=file

[log.level]
label=debug
value=10

`
10 changes: 10 additions & 0 deletions test/foo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,13 @@ test('encode with align and sort', function (t) {
t.matchSnapshot(e)
t.end()
})

test('encode within browser context', function (t) {
Object.defineProperty(process, 'platform', { value: undefined })

const obj = { log: { type: 'file', level: { label: 'debug', value: 10 } } }
const e = i.encode(obj)

t.matchSnapshot(e)
t.end()
})