[BUG] semver.satisfies("9007199254740991.9007199254740991.9007199254740991--", "~9007199254740991.9007199254740991.9007199254740991-1") returns false

[martijnhoekstra]

What / Why

semver.satisfies("9007199254740991.9007199254740991.9007199254740991--", "~9007199254740991.9007199254740991.9007199254740991-1")

returns false whereas I'd expect it to return true. Note that 9007199254740991 is max safe int, and replacing all those with 1 makes it return true.

When

• every time I call the method with those parameters.

Where

• npm/node-semver

How

Current Behavior

• call semver.satisfies("9007199254740991.9007199254740991.9007199254740991--", "~9007199254740991.9007199254740991.9007199254740991-1")
• false is returned

Steps to Reproduce

• call semver.satisfies("9007199254740991.9007199254740991.9007199254740991--", "~9007199254740991.9007199254740991.9007199254740991-1")

Expected Behavior

• true is returned

Who

• I don't know

References

• I don't know

[lukekarrys]

By design the maximum value for any semver component is Number.MAX_SAFE_INTEGER. So 9007199254740991.9007199254740991.9007199254740991 is a valid version. But in order to create the range ~9007199254740991.9007199254740991.900719925474099 it has to increment the minor component which results in an invalid version being created in order to create the range:

> new semver.Range('~9007199254740991.9007199254740991.900719925474099')
Uncaught TypeError: Invalid minor version

semver.satisfies catches any error and returns false which might seem weird in this case since the range isn't obviously invalid, but that's what it does for all cases:

> semver.satisfies("1.0.0", "hello")
false

I created #450 to add an explicit test for this behavior, but I don't see any way around fixing this.