Skip to content

RFC: Add npm workspaces #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

RFC: Add npm workspaces #103

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fe71372
RFC: Add npm workspaces
ruyadorno Feb 14, 2020
e8221f4
Update accepted/0000-workspaces.md
ruyadorno Feb 17, 2020
a350c72
Update accepted/0000-workspaces.md
ruyadorno Feb 17, 2020
2596463
Update accepted/0000-workspaces.md
ruyadorno Feb 19, 2020
c279a49
Question: opt-out config?
ruyadorno Feb 20, 2020
de8d71c
Incorporated feedback from the deep-dive call
ruyadorno Mar 11, 2020
25b1683
Add feedback about run-scripts
ruyadorno Mar 17, 2020
102660c
Moved run commands to its own RFC
ruyadorno Mar 19, 2020
3335cf7
Added ref to negative globs config
ruyadorno Mar 19, 2020
8a5080c
Clean up example title
ruyadorno Mar 19, 2020
26e8ac6
Removed unresolved questions
ruyadorno Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed unresolved questions
  • Loading branch information
@ruyadorno
ruyadorno committed Mar 26, 2020
commit 26e8ac6ee176943d6522d5d057fab05e37655e1c
6 changes: 0 additions & 6 deletions accepted/0000-workspaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,3 @@ During the discussions around this RFC it was brought up to our attention that a
- [Lerna](https://github.com/lerna/lerna)
- [Yarn workspaces](https://classic.yarnpkg.com/en/docs/workspaces/)
- [Pnpm workspaces](https://pnpm.js.org/en/workspaces)

## Unresolved Questions and Bikeshedding

- Should we support an opt-out config? e.g: `workspacesEnabled`
- Should we prevent **publish** of the **Top-level workspace** package? Previous note on it:
- A **Top-level workspace** package may not be published to the registry and for all publishing purposes having a valid `"workspaces"` entry in a `package.json` is going to be the equivalent of `"private": true`.