feat(webpack): create build log for remotes to help debug errors #22539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
Coly010
approved these changes
Mar 27, 2024
Contributor
Coly010
left a comment
Coly010
left a comment
There was a problem hiding this comment.
One comment duplicated just, but LGTM
Comment on lines
+5
to
+7
| import { fork } from 'node:child_process'; | ||
| import { join } from 'node:path'; | ||
| import { createWriteStream } from 'node:fs'; |
Contributor
There was a problem hiding this comment.
Will we run into issues with this style of import for users on older versions of Node?
Member
Author
There was a problem hiding this comment.
It's supported since Node 16, and we already use it in a few places.
Comment on lines
+22
to
+24
| import { fork } from 'node:child_process'; | ||
| import { basename, dirname, join } from 'node:path'; | ||
| import { createWriteStream, cpSync } from 'node:fs'; |
Member
Author
|
Merging this sine the failure is related to The failing |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a log file for users to inspect whenever the remotes fail to build.
Users will see an error like this when serving host fails at the build step:
Current Behavior
Errors are swallowed since
run-manyis logging to stdout.Expected Behavior
Errors should be surfaced, in this case, via a build log file.
Related Issue(s)
Fixes #