Skip to content

Report VM clone progress #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
otwieracz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Report VM clone progress #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da4d084
Report VM clone progress
otwieracz Aug 22, 2017
395ae8f
Fix style issues
otwieracz Aug 22, 2017
5818ced
Fix tests
otwieracz Aug 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/vSphere/action/clone.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,14 @@ def call(env)
env[:ui].info " -- #{config.clone_from_vm ? 'Source' : 'Template'} VM: #{template.pretty_path}"
env[:ui].info " -- Target VM: #{vm_base_folder.pretty_path}/#{name}"

new_vm = template.CloneVM_Task(folder: vm_base_folder, name: name, spec: spec).wait_for_completion
last_progress = 0
new_vm = template.CloneVM_Task(folder: vm_base_folder, name: name, spec: spec).wait_for_progress do |progress|
if (progress.is_a? Numeric) && (progress/10).floor != (last_progress/10).floor
env[:ui].info "Progress: #{progress}%"
last_progress = progress
end
end
env[:ui].info "Done!"

config.custom_attributes.each do |k, v|
env[:ui].info "Setting custom attribute: #{k}=#{v}"
Expand Down
3 changes: 2 additions & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ def call
parent: @data_center,
pretty_path: "#{@data_center.pretty_path}/template_vm",
CloneVM_Task: double('result',
wait_for_completion: double('new_vm', config: double('config', uuid: NEW_UUID))),
wait_for_completion: double('new_vm', config: double('config', uuid: NEW_UUID)),
wait_for_progress: double('new_vm', config: double('config', uuid: NEW_UUID))),
config: @template_config)

@data_center.stub(:find_vm).with(TEMPLATE).and_return(@template)
Expand Down