Improvements of pcap handling #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing a Header to pcap, it should not be modified and thus be passed as a constant. This commits adds a sink to export Header along the packet. This is done for performance reasons, to prevent the (costly) creation of a new packet with the header. I've also modified some tests to remove unnecessary data copy via using the overload that accepts a packet as a parameter.
Contributor
Author
|
Closed due to diff committed by vedranm (368aa19) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a Header to pcap, it should not be modified and thus be
passed as a constant.
Adds a sink to export Header along the packet for performance reasons (prevent creating a new Packet).
I've also simplified some tests to remove unnecessary data copy.